Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Update Svelte template to Svelte 5 #1184

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Conversation

PatatoBit
Copy link
Contributor

using new App() no longer works in Svelte 5. I updated the example template to Svelte 5. Though there is still a type error which can be fixed using this. But I just reckoned the code would've been too complicated.

const target = document.getElementById("app");
let app;
if (target) {
  app = mount(App, { target });
} else {
  throw new Error("Target element not found");
}

I found this after finding where it doesn't work. This is actually my first time using wxt so I took a while for it as I really want to use Svelte.

Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 0d0728a
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/673a5774a6956300089296f6
😎 Deploy Preview https://deploy-preview-1184--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Timeraa Timeraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I don't use Svelte so I'll let @aklinker1 merge this

Copy link

pkg-pr-new bot commented Nov 17, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@1184

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@1184

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@1184

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@1184

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@1184

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@1184

@wxt-dev/storage

pnpm add https://pkg.pr.new/@wxt-dev/storage@1184

@wxt-dev/unocss

pnpm add https://pkg.pr.new/@wxt-dev/unocss@1184

wxt

pnpm add https://pkg.pr.new/wxt@1184

commit: 0d0728a

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.65%. Comparing base (226e6c9) to head (0d0728a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
+ Coverage   80.42%   80.65%   +0.23%     
==========================================
  Files         127      127              
  Lines        6070     6070              
  Branches     1021     1020       -1     
==========================================
+ Hits         4882     4896      +14     
+ Misses       1173     1159      -14     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 changed the title Updated Svelte example template to Svelte 5 chore: Update Svelte template to Svelte 5 Nov 17, 2024
@aklinker1 aklinker1 merged commit cfdc6b3 into wxt-dev:main Nov 17, 2024
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants