Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Upgrade vite-plugin-svelte to support Vite 6 #1375

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Jan 28, 2025

Overview

Bump dependencies.

(This bumps the lockfile to Vite v6, which could be an issue)

Manual Testing

???

Related Issue

This PR closes #1374.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit abc3cb7
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67994633adcaea000804c9d7
😎 Deploy Preview https://deploy-preview-1375--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change? Does the new plugin still support Vite 5?

@aklinker1 aklinker1 changed the title Bump vite-plugin-svelte fix: Upgrade vite-plugin-svelte to support Vite 6 Jan 28, 2025
Copy link

pkg-pr-new bot commented Jan 28, 2025

Open in Stackblitz

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1375

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1375

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1375

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1375

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1375

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1375

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1375

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1375

wxt

npm i https://pkg.pr.new/wxt@1375

commit: abc3cb7

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (5b6c82d) to head (abc3cb7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
+ Coverage   81.05%   81.11%   +0.06%     
==========================================
  Files         128      128              
  Lines        6296     6296              
  Branches     1069     1070       +1     
==========================================
+ Hits         5103     5107       +4     
+ Misses       1178     1174       -4     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1
Copy link
Collaborator

Failing check is my fault, merge your branch with latest main and it will pass.

@lishaduck lishaduck force-pushed the vite-plugin-svelte-5 branch from 97721c8 to 2aaf0f5 Compare January 28, 2025 20:58
@lishaduck
Copy link
Contributor Author

Failing check is my fault, merge your branch with latest main and it will pass.

There you go!

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@aklinker1 aklinker1 merged commit e9b6f5f into wxt-dev:main Jan 28, 2025
18 checks passed
@lishaduck lishaduck deleted the vite-plugin-svelte-5 branch March 8, 2025 22:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update vite-plugin-svelte
2 participants