Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix success status when action failed #111

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Fix success status when action failed #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0d95e6
make `firebase` the last command in the script
kaibolay Jun 20, 2023
ae5e769
tests: add fail check in tests suite
wzieba Jun 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,23 @@ jobs:
testers: "test@test.com, test2@test2.com"
releaseNotesFile: README.md
file: ApiDemos-debug.apk
- name: Failure during upload should set failure in action step
id: fail_check
uses: ./
continue-on-error: true
with:
appId: invalid_app_id
token: ${{secrets.FIREBASE_TOKEN}}
testers: "test@test.com, test2@test2.com"
releaseNotesFile: README.md
file: ApiDemos-debug.apk
- name: Check if previous step failed as expected
run: |
if [[ "${{ steps.fail_check.outcome }}" == 'failure' ]]; then
echo "Previous step failed as expected"
exit 0
else
echo "Previous step succeeded, when it shouldn't"
exit 1
fi

4 changes: 0 additions & 4 deletions entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,3 @@ firebase \
${RELEASE_NOTES:+ --release-notes "${RELEASE_NOTES}"} \
${INPUT_RELEASENOTESFILE:+ --release-notes-file "${RELEASE_NOTES_FILE}"} \
$( (( $INPUT_DEBUG )) && printf %s '--debug' )

if [ -n "${INPUT_TOKEN}" ] ; then
echo ${TOKEN_DEPRECATED_WARNING_MESSAGE}
fi