Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature Fixes and Updates #13

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Feature Fixes and Updates #13

merged 4 commits into from
Jul 27, 2022

Conversation

xViperAG
Copy link
Contributor

No description provided.

@xFutte xFutte self-assigned this Jul 27, 2022
@xFutte
Copy link
Owner

xFutte commented Jul 27, 2022

@xViperAG Thanks for helping with making the script even better. I really like the idea, but the current code doesn't, after testing it locally, get rid of the newspaper prop from the body when closing the newspaper.

@xViperAG
Copy link
Contributor Author

So it had worked perfectly for me and I did it numerous times to make sure of it.

Since it's a client side thing might require a cache clear on either user side or server side just to make sure

@xFutte
Copy link
Owner

xFutte commented Jul 27, 2022

So it had worked perfectly for me and I did it numerous times to make sure of it.

Since it's a client side thing might require a cache clear on either user side or server side just to make sure

Good point. I'll give it a go and see.

Copy link
Owner

@xFutte xFutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as intended after clearing the cache. Will be merged master. Thanks.

@xFutte xFutte merged commit eafe5b5 into xFutte:master Jul 27, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants