Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow map_in_place to be called when the callee is already panicking. #300

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Allow map_in_place to be called when the callee is already panicking. #300

merged 1 commit into from
Jun 17, 2024

Conversation

dtzxporter
Copy link
Contributor

  • Forget the abort on panic once we know the closure did not panic.

@dtzxporter
Allow map_in_place to be called then the callee is already panicking.
97c0faf 
- Forget the abort on panic once we know the closure did not panic.

Update util.rs
@dtzxporter dtzxporter changed the title Allow map_in_place to be called then the callee is already panicking. Allow map_in_place to be called when the callee is already panicking. Apr 24, 2024
@dtzxporter
Copy link
Contributor Author

CI issue is unrelated to PR

@dtzxporter
Copy link
Contributor Author

@xacrimon Gentle bump on this, it's a pretty harmless change that makes the api usable in Drop(s) where the callee has panicked!

@xacrimon
Copy link
Owner

@dtzxporter Apologies for the delay. Thanks for this! Will put out a new version this week.

@xacrimon xacrimon merged commit 5514533 into xacrimon:master Jun 17, 2024
1 of 6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzxporter @xacrimon