Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix 9939 [iOS][UWP] Dispose method not called when adding control inside the NavigationPage.TitleView #10152

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Fix 9939 [iOS][UWP] Dispose method not called when adding control inside the NavigationPage.TitleView #10152

merged 2 commits into from
Apr 3, 2020

Conversation

yurkinh
Copy link
Contributor

@yurkinh yurkinh commented Mar 31, 2020 •
edited
Loading

Description of Change

Dispose() method is not called for a custom view added to TitleView on iOS and UWP

Issues Resolved

Platforms Affected

  • iOS
  • UWP

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@yurkinh yurkinh marked this pull request as ready for review March 31, 2020 16:29
@jsuarezruiz
Copy link
Contributor

On Android we are disposing the TitleView here:

Xamarin.Forms/Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs

Line 215 in 17a0497

_titleView?.Dispose();

@samhouts samhouts merged commit e4e3939 into xamarin:4.5.0 Apr 3, 2020
@yurkinh yurkinh deleted the fix-9939 branch April 4, 2020 20:20
@samhouts samhouts added this to the 4.5.0 milestone Apr 9, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@samhouts samhouts samhouts approved these changes

Assignees
No one assigned
Labels
a/lifecycleevents a/titleview p/iOS 🍎 p/UWP t/bug 🐛
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yurkinh @jsuarezruiz @samhouts