Update Slack integration

[svanharmelen]

Fixes #2039

[jgangemi]

this should include this as well:

        LabelsToBeNotified         string `json:"labels_to_be_notified,omitempty"`
	LabelsToBeNotifiedBehavior string `json:"labels_to_be_notified_behavior,omitempty"`
	PushChannel                string `json:"push_channel,omitempty"`
	IssueChannel               string `json:"issue_channel,omitempty"`
	ConfidentialIssueChannel   string `json:"confidential_issue_channel,omitempty"`
	MergeRequestChannel        string `json:"merge_request_channel,omitempty"`
	NoteChannel                string `json:"note_channel,omitempty"`
	ConfidentialNoteChannel    string `json:"confidential_note_channel,omitempty"`
	TagPushChannel             string `json:"tag_push_channel,omitempty"`
	PipelineChannel            string `json:"pipeline_channel,omitempty"`
	WikiPageChannel            string `json:"wiki_page_channel,omitempty"`
	DeploymentChannel          string `json:"deployment_channel,omitempty"`
	IncidentChannel            string `json:"incident_channel,omitempty"`
	VulnerabilityChannel       string `json:"vulnerability_channel,omitempty"`
	AlertChannel               string `json:"alert_channel,omitempty"`

[jgangemi]

aside from the missing fields i mentioned, this appears to be working.

is it possible to change the SetSlackApplication to return the SlackApplicationProperties struct w/ the response instead of needing to get another get call?

[svanharmelen]

Nice catch, added them to the struct 👍🏻 And no, the API doesn't return the properties on the PUT call, so it needs another GET call is you want the updated/saved properties from the server...

[jgangemi]

it does - all the json output from our discussion in #2040 was from the PUT request.

[jgangemi]

settings := new(SlackApplication)
req, err := s.client.NewRequest(http.MethodPut, u, opt, options)
if err != nil {
	return nil, err
}

resp, err := s.client.Do(req, &settings)
fmt.Println("-- SetSlackApplication --")
fmt.Printf("Inheritted: %t\n", settings.Inherited)
fmt.Println("-- SetSlackApplication --")

go run slack-test.go
--- GET ---
Service Id: 128662996
Inherited: false
Channel: 
Alert Events: false
Alert Channel: 
-- SetSlackApplication --
Inheritted: true
-- SetSlackApplication --
--- GET ---
Service Id: 128662996
Inherited: true
Channel: 
Alert Events: false
Alert Channel: 

[svanharmelen]

I guess this should fix it, but the tests now fail 😏 Yet I'm out of time to spend on this for now, so will have another look next weekend or so...

[jgangemi]

if you don't have time for this right now i can take a look at fixing the tests, i'd like to see this get merged b/c i'd like to start work on the terraform resource for it.

[svanharmelen]

Thanks you very much for the help @jgangemi!