opam: dunify vhd-tool's metadata #5872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add missing dependencies added recently Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
edwintorok
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
We can probably drop this one completely once my opam file reduction branch is ready,
although it is an upstream project, so we may want to merge all of it back upstream.
Another option is to use dune's "vendored dirs" feature and treat it as a purely vendored upstream repo, in which case we can move the opam file into a subdir.
But I see we've added a lot of XAPI-specific things already, like forkexec here though.
Vincent-lau
approved these changes
Jul 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add missing dependencies added recently
This fixes builds in xs-opam, see xapi-project/xs-opam#691