Refactor parts of Xapi_event #6292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Precomputes the list of names of objects for which "gen_events" is true. This was done in another place to populate a hash table, so we relocate and redefine this function in terms of this precomputed list. Signed-off-by: Colin James <colin.barr@cloud.com>
Signed-off-by: Colin James <colin.barr@cloud.com>
This is stylistic only as it affects the event.next API, which is considered deprecated. Signed-off-by: Colin James <colin.barr@cloud.com>
Signed-off-by: Colin James <colin.barr@cloud.com>
The current style uses a lot of nesting (and a shadow of `s`) and, due to the formatting rules, the code is awkwardly indented to the right. Instead, filter for events (performing the relevant side effect of updatnig the event number) without a fold. The resulting sequence being non-empty implies a match, rather than propagating `true` through a fold. Signed-off-by: Colin James <colin.barr@cloud.com>
Comments of individual fields should appear before the delimiting `;`. Signed-off-by: Colin James <colin.barr@cloud.com>
Signed-off-by: Colin James <colin.barr@cloud.com>
Signed-off-by: Colin James <colin.barr@cloud.com>
|
Turns out this series also has the bug. Closing. |
psafont
reviewed
Feb 11, 2025
Comment on lines
+410
to
+411
| Hashtbl.find_opt calls session_id |> Option.iter invalidate ; | ||
| Hashtbl.remove calls session_id |
There was a problem hiding this comment.
This change is fine because Hashtbl.remove is idempotent
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the less interesting (stylistic) commits from another branch. I'm yet to upstream the other branch because its other commits cause spurious failures in test.