Replace startswith and endswith with stdlib calls #6299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last-genius
approved these changes
Feb 13, 2025
lindig
approved these changes
Feb 13, 2025
psafont
approved these changes
Feb 13, 2025
|
Coveralls upload is failing because it's under maintenance |
|
The code is good. The commit message a bit misleading. Maybe Minor anyway, feel free to ignore |
freddy77
approved these changes
Feb 13, 2025
contificate
force-pushed
the
startswith
branch
from
0c2b676 to
b225a18
Compare
contificate
changed the title
Fair point; I've rewritten the commit message and renamed this PR (so any merge commit isn't inconsistently named). |
Drops `startswith` and `endswith` from `String` (within `xapi-stdext/xapi-stdext-std`). These functions were introduced in OCaml 4.13: ``` String.starts_with : prefix:string -> string -> bool ``` Usage sites are adapted to supply the relevant labelled argument in each case, e.g. ~prefix:"foo". Signed-off-by: Colin James <colin.barr@cloud.com>
contificate
force-pushed
the
startswith
branch
from
b225a18 to
aca86bc
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions were introduced in OCaml 4.13.