ocaml: add 4.14 #619
Merged
ocaml: add 4.14 #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
approved these changes
Dec 9, 2022
psafont
force-pushed
the
4.14
branch
3 times, most recently
from
0467112 to
2ae3ed8
Compare
psafont
force-pushed
the
4.14
branch
5 times, most recently
from
cf0c3bd to
c1cce00
Compare
psafont
force-pushed
the
4.14
branch
2 times, most recently
from
c9ee381 to
886cae7
Compare
|
Dune 3.7 is nearly ready, we may want to include that to also get the bugfix for binary corruption: ocaml/opam-repository#23349 |
edwintorok
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
The changes here look good. We might need to adjust a few of the tools/scripts to work with 2 compilers, I can attempt to do those tweaks once the other PR is merged.
psafont
force-pushed
the
4.14
branch
5 times, most recently
from
68aed90 to
9d6ba05
Compare
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
This version is compatible with 4.14 only Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Allow for duplicate packages for ocaml 4.14 Adapt unused packages for new ocamlformat Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update packages to be compatible with ocaml 4.14.
Some packages around ocamlformat need to have 2 versions to be able to work in both versions of the compilers, this affects the artifacts that generated from this version.
Because the ocamlformat version has been changed once we move to ocaml 4.14 the formatting of xapi will need to change accordingly
I would rather wait until 4.14.1 is available before merging this, it is probably a good idea to merge the upstream changes before this one as well.