Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Patch Uri packages to add path_unencoded #693

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

last-genius
Copy link
Contributor

@last-genius last-genius commented Jul 23, 2024

Until Uri is versioned out into a new tag, we will need to use this patched version pointing to a commit hash. This is required for the xen-api percent-decoding PR: xapi-project/xen-api#5877

Signed-off-by: Andrii Sultanov <andrii.sultanov@cloud.com>
@last-genius
Copy link
Contributor Author

This was tested with the percent-decoding changes (BST/BVT run ID 201742)

Copy link
Member

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hash matches the merge commit for the patch that includes the unencoded function: mirage/ocaml-uri@8d6da91

Copy link
Collaborator

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know it was possible to point to a commit for an archive. This makes it a lot easier than using patches.

@psafont psafont merged commit 02ab46c into xapi-project:master Jul 23, 2024
3 checks passed
@last-genius last-genius deleted the uri-patch branch July 23, 2024 13:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants