Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add promise rejection for invalid files #10

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Add promise rejection for invalid files #10

merged 1 commit into from
Jan 26, 2018

Conversation

josephnle
Copy link
Contributor

  • Catches promise rejection in sketch2json.js and passes to the Promise's reject().
  • Adds test for ingesting invalid files

Fixes #9

@josephnle josephnle force-pushed the check-for-valid-zip branch from 0f56b7f to eb9d8c4 Compare January 26, 2018 01:57
@xaviervia
Copy link
Owner

Awesome! Thanks a lot!

@xaviervia xaviervia merged commit b286132 into xaviervia:master Jan 26, 2018
@xaviervia
Copy link
Owner

Released https://github.com/xaviervia/sketch2json/releases/tag/v0.1.2

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephnle @xaviervia