Skip to content

Commit

Permalink
xen/arch/x86: make objdump output user locale agnostic
Browse files Browse the repository at this point in the history
The objdump output is fed to grep, so make sure it doesn't change with
different user locales and break the grep parsing.
This problem was identified while updating xen in Debian and the fix is
needed for generating reproducible builds in varying environments.

Signed-off-by: Maximilian Engelhardt <maxi@daemonizer.de>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
  • Loading branch information
Maximilian Engelhardt authored and andyhhp committed Dec 30, 2024
1 parent 6e1036b commit 0d72922
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion xen/arch/x86/arch.mk
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ endif
ifeq ($(XEN_BUILD_PE),y)

# Check if the linker produces fixups in PE by default
efi-nr-fixups := $(shell $(OBJDUMP) -p $(efi-check).efi | grep '^[[:blank:]]*reloc[[:blank:]]*[0-9][[:blank:]].*DIR64$$' | wc -l)
efi-nr-fixups := $(shell LC_ALL=C $(OBJDUMP) -p $(efi-check).efi | grep '^[[:blank:]]*reloc[[:blank:]]*[0-9][[:blank:]].*DIR64$$' | wc -l)

ifeq ($(efi-nr-fixups),2)
MKRELOC := :
Expand Down

0 comments on commit 0d72922

Please # to comment.