Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Alfredops 856 #158

Closed
wants to merge 2 commits into from
Closed

Alfredops 856 #158

wants to merge 2 commits into from

Conversation

Brobrechts
Copy link

Updated Readme.md to prevent a configuration bug that causes log4j2 logging to fail

  • updated dependencies that are no longer available to nearest version.

@@ -1,5 +1,5 @@
plugins {
id 'eu.xenit.docker-compose' version '5.3.2' apply false
id 'eu.xenit.docker-compose' version '5.5.0' apply false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose files have to be upgrade to V3.x

version: '3.2' (Found in docker.yml files). This comment can be ignored.

Copy link

@codingBenVdS codingBenVdS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade for docker-compose V5.3.2 -> V5.5.0
Fixing the community version numbers.

@@ -1,5 +1,5 @@
ext {
alfrescoBaseWarBom = 'org.alfresco:acs-community-packaging:6.2.1-A7'
alfrescoBaseWarBom = 'org.alfresco:acs-community-packaging:6.3.0-repo-4735-2-15'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a weird version that can potentially be removed in future?

@todorinskiz
Copy link
Member

Fixed here #161

@Brobrechts
Copy link
Author

@todorinskiz
It's fine to close this branch, but we still need the Readme update to exclude the log4j2 dependency no?
(in the case for community editions)

alfrescoSM(group: 'io.github.mweirauch', name: 'micrometer-jvm-extras', version: "${jvmExtrasVersion}")
{
exclude group: "org.slf4j", module: "*"
}

Pullling in his depededency without the exclusion will put 2 different versions for sl4j on the path, which can cause total absence of logs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants