CA-142238: Fix parsing lvmohba probe xml #23
Conversation
|
I've haven't committed the unit tests as the travis changes haven't been merged yet. I've kicked off a few XenRT jobs and they've all passed without introducing any new failures :) |
|
@siddharthv - I thought we agreed you're gonna add unit tests for that. Not having a CI system does not prevent you from writing unit tests. Please try a bit harder. Do not merge this. |
|
If I may weigh in, let's find a compromise between urgency of code and unit tests. |
|
Sure thing. |
With xs64bit, sr-probe has attributes like supported_speeds which have comma separated values that break the exising parser. This patch ensures that we don't break the required xml even if the exception contains additional tags with comma separated values. Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com>
|
@matelakat created #24 to address unit test concerns. |
|
@siddharthv - please separate functions with two lines, that's a PEP8 rule. Once you are done with it, please merge the change. If the merge process has already been started, just leave it as it is. |
With xs64bit, sr-probe has attributes like supported_speeds
which have comma separated values that break the exising parser.
This patch uses a different methodology to obtain the required xml.
Signed-off-by: Siddharth Vinothkumar siddharth.vinothkumar@citrix.com