Skip to content

Use dyn for a dynamic trait #1332

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Use dyn for a dynamic trait #1332

merged 1 commit into from
Jun 4, 2019

Conversation

linkmauve
Copy link
Contributor

Muxer is a trait, and passing dynamic traits without the dyn keyword is now deprecated.

`Muxer` is a trait, and passing dynamic traits without the `dyn` keyword is now deprecated.
@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 83.177% when pulling a51c710 on linkmauve:patch-1 into 12f041f on xiph:master.

Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting it :)

I checked with #![deny(bare_trait_objects)] that the rest of the codebase is clean.

@lu-zero lu-zero merged commit b9bccd1 into xiph:master Jun 4, 2019
@linkmauve linkmauve deleted the patch-1 branch June 4, 2019 10:03
@linkmauve
Copy link
Contributor Author

Maybe we should add this deny crate-wide?

@lu-zero
Copy link
Collaborator

lu-zero commented Jun 4, 2019

Could be a good idea let see what the team thinks :)

@shssoichiro
Copy link
Collaborator

It will at the least be warn by default in an upcoming rustc (slated for 1.37): rust-lang/rust#61203. But we may want to change it before then.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants