fix empty databuf bug in DataPageV2 #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolstein
pushed a commit
to zolstein/parquet-go
that referenced
this pull request
Jun 23, 2023
…itongsys#289) * refactor packages to use encoding.Values container * refactor page and dictionary creation to use encoding.Values * go vet fix * reduce memory footprint of encoding.Values * refactor encoding.Encoding to use simple Go types * port parquet-go package to use pair of values+offsets to represent byte arrays * add fuzz tests back * optimize DELTA_LENGTH_BYTE_ARRAY decoding (xitongsys#291) * optimize DELTA_LENGTH_BYTE_ARRAY decoding * add link to online documentation * fix * add a unit test for decodeByteArrayLengths * Update encoding/delta/length_byte_array_amd64.s Co-authored-by: Kevin Burke <kevin.burke@segment.com> * optimize DELTA_LENGTH_BYTE_ARRAY encoding (xitongsys#292) Co-authored-by: Kevin Burke <kevin.burke@segment.com> * account for size of offsets buffer when benchmarking throughput * optimize DELTA_BYTE_ARRAY decoding (xitongsys#294) * PR feedback Co-authored-by: Kevin Burke <kevin.burke@segment.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.