Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: replace BFS with DFS in sync_txn_request #504

Closed
wants to merge 1 commit into from

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Nov 3, 2023

Close: #498
Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fe5b7de) 54.17% compared to head (1576dd9) 54.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   54.17%   54.19%   +0.01%     
==========================================
  Files         101      101              
  Lines       18239    18237       -2     
  Branches    18239    18237       -2     
==========================================
+ Hits         9881     9883       +2     
+ Misses       7768     7765       -3     
+ Partials      590      589       -1     
Files Coverage Δ
xline/src/server/command.rs 68.98% <0.00%> (-0.11%) ⬇️
xline/src/storage/kv_store.rs 71.90% <66.66%> (-0.19%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
@bsbds bsbds marked this pull request as ready for review November 7, 2023 01:53
@bsbds bsbds marked this pull request as draft November 14, 2023 06:36
@bsbds
Copy link
Collaborator Author

bsbds commented Jan 4, 2024

After refactoring this PR is no longer needed.

@bsbds bsbds closed this Jan 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: sync txn request does not execute in the order of child request
1 participant