removed commented out tests

xmidt-org · Jan 30, 2025 · 57a0860 · 57a0860
1 parent 7435056
commit 57a0860
Showing 1 changed file with 1 addition and 205 deletions.
diff --git a/internal/dns/srvRecordDialer_test.go b/internal/dns/srvRecordDialer_test.go
@@ -79,208 +79,4 @@ func (suite *DnsSuite) TestDialContext() {
 
 	suite.NotNil(conn)
 	suite.NoError(err)
-}
-
-// func TestNewSRVRecordDialer(t *testing.T) {
-// 	tests := []struct {
-// 		name     string
-// 		fqdns    []string
-// 		sortBy   string
-// 		resolver Resolver
-// 	}{
-// 		{
-// 			name: "empty fqdn",
-// 		},
-// 		{
-// 			name:   "valid fqdn - priority sort",
-// 			fqdns:  []string{"example.org."},
-// 			sortBy: "priority",
-// 			resolver: &mockdns.Resolver{
-// 				Zones: map[string]mockdns.Zone{
-// 					"_._.example.org.": {
-// 						SRV: []net.SRV{
-// 							{
-// 								Target:   "valid.example.com",
-// 								Port:     443,
-// 								Priority: 1,
-// 								Weight:   50,
-// 							},
-// 						},
-// 					},
-// 				},
-// 			},
-// 		},
-// 		{
-// 			name:   "invalid fqdn",
-// 			fqdns:  []string{"invalid.example.org"},
-// 			sortBy: "priority",
-// 			resolver: &mockdns.Resolver{
-// 				Zones: map[string]mockdns.Zone{
-// 					"_._.example.org.": {
-// 						SRV: []net.SRV{
-// 							{
-// 								Target:   "valid.example.com",
-// 								Port:     443,
-// 								Priority: 1,
-// 								Weight:   50,
-// 							},
-// 						},
-// 					},
-// 				},
-// 			},
-// 		},
-// 	}
-
-// 	for _, tt := range tests {
-// 		t.Run(tt.name, func(t *testing.T) {
-// 			dialer := NewSRVRecordDialer(WithResolver(tt.resolver), WithFQDNS(tt.fqdns))
-// 			assert.NotNil(t, dialer)
-
-// 		})
-// 	}
-// }
-
-// func TestDialContext(t *testing.T) {
-// 	tests := []struct {
-// 		name          string
-// 		fqdns         []string
-// 		chooser       Chooser
-// 		resolver      Resolver
-// 		expectedError bool
-// 	}{
-// 		{
-// 			name:  "valid fqdn - weight sort",
-// 			fqdns: []string{"example.org."},
-// 			chooser: &WeightChooser{
-// 				srvs: []*net.SRV{
-// 					{
-// 						Target:   "example.com",
-// 						Port:     443,
-// 						Priority: 1,
-// 						Weight:   100,
-// 					},
-// 					{
-// 						Target:   "valid2.example.com",
-// 						Port:     443,
-// 						Priority: 1,
-// 						Weight:   50,
-// 					},
-// 				},
-// 			},
-// 			resolver: &mockdns.Resolver{
-// 				Zones: map[string]mockdns.Zone{
-// 					"_._.example.org.": {
-// 						SRV: []net.SRV{
-// 							{
-// 								Target:   "example.com",
-// 								Port:     443,
-// 								Priority: 1,
-// 								Weight:   100,
-// 							},
-// 							{
-// 								Target:   "valid2.example.com",
-// 								Port:     443,
-// 								Priority: 1,
-// 								Weight:   50,
-// 							},
-// 						},
-// 					},
-// 				},
-// 			},
-// 			expectedError: false,
-// 		},
-// 		{
-// 			name:  "valid fqdn - priority sort",
-// 			fqdns: []string{"example.org."},
-// 			chooser: &PriorityChooser{
-// 				srvs: []*net.SRV{
-// 					{
-// 						Target:   "example.com",
-// 						Port:     443,
-// 						Priority: 1,
-// 						Weight:   50,
-// 					},
-// 					{
-// 						Target:   "valid2.example.com",
-// 						Port:     443,
-// 						Priority: 2,
-// 						Weight:   50,
-// 					},
-// 				},
-// 			},
-// 			resolver: &mockdns.Resolver{
-// 				Zones: map[string]mockdns.Zone{
-// 					"_._.example.org.": {
-// 						SRV: []net.SRV{
-// 							{
-// 								Target:   "example.com",
-// 								Port:     443,
-// 								Priority: 1,
-// 								Weight:   50,
-// 							},
-// 							{
-// 								Target:   "valid2.example.com",
-// 								Port:     443,
-// 								Priority: 2,
-// 								Weight:   50,
-// 							},
-// 						},
-// 					},
-// 				},
-// 			},
-// 			expectedError: false,
-// 		},
-// 		{
-// 			name:  "invalid fqdn",
-// 			fqdns: []string{"invalid.example.org"},
-// 			chooser: &PriorityChooser{
-// 				srvs: []*net.SRV{
-// 					{
-// 						Target:   "valid.example.com",
-// 						Port:     443,
-// 						Priority: 1,
-// 						Weight:   50,
-// 					},
-// 				},
-// 			},
-// 			resolver: &mockdns.Resolver{
-// 				Zones: map[string]mockdns.Zone{
-// 					"_._.example.org.": {
-// 						SRV: []net.SRV{
-// 							{
-// 								Target:   "valid.example.com",
-// 								Port:     443,
-// 								Priority: 1,
-// 								Weight:   50,
-// 							},
-// 						},
-// 					},
-// 				},
-// 			},
-// 			expectedError: true,
-// 		},
-// 	}
-
-// 	for _, tt := range tests {
-// 		t.Run(tt.name, func(t *testing.T) {
-// 			dialer, err := NewRoundTripper(WithFQDNS(tt.fqdns), WithChooser(tt.chooser), WithResolver(tt.resolver))
-// 			if tt.expectedError {
-// 				assert.Error(t, err)
-// 				return
-// 			}
-// 			assert.NoError(t, err)
-// 			assert.NotNil(t, dialer)
-
-// 			srvDialer, ok := dialer.(*http.Transport)
-// 			assert.True(t, ok)
-
-// 			conn, err := srvDialer.DialContext(context.Background(), "", "")
-// 			if tt.expectedError {
-// 				assert.Error(t, err)
-// 			} else {
-// 				assert.NoError(t, err)
-// 				assert.NotNil(t, conn)
-// 			}
-// 		})
-// 	}
-// }
+}