Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pause/resume/hashrate problem #49

Closed
Sinner181 opened this issue Feb 9, 2018 · 3 comments
Closed

Pause/resume/hashrate problem #49

Sinner181 opened this issue Feb 9, 2018 · 3 comments
Labels

Comments

@Sinner181
Copy link

Hi,
when a external command was submitted to your application, I receive an unlimted loop.

with sendmessage or postmessage only work correcly RESUME function ("r" char).

PAUSE and HASHRATE generate an unlimits row like:
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:09] paused, press r to resume
[2018-01-09 03:02:10] paused, press r to resume
[2018-01-09 03:02:10] paused, press r to resume
[2018-01-09 03:02:10] paused, press r to resume
[2018-01-09 03:02:10] paused, press r to resume

I've try with normal cmd.exe and sendmessage/postmessage send correctly only one char, your application goes in a infinite loop and crash after some minutes.

Can you fix? repeat, ONLY Resume work correctly if sendmessage/postmessage send an "r" char.

SOLUTION FOR CPU MINER IS:
case 'p':
case 'P':

  •    LOG_INFO(m_options->colors() ? "\x1B[01;33mpaused\x1B[0m, press \x1B[01;35mr\x1B[0m to resume" : "paused, press 'r' to resume");
    
  •    Workers::setEnabled(false);
    
  •    if (Workers::isEnabled()) {
    
  •        LOG_INFO(m_options->colors() ? "\x1B[01;33mpaused\x1B[0m, press \x1B[01;35mr\x1B[0m to resume" : "paused, press 'r' to resume");
    
  •        Workers::setEnabled(false);
    
  •    }
       break;
    

    case 'r':

in src/App.cpp I think is the same.

Can you rebuild with this fix in new 2.4.3 version? Last update was in 23 Oct 2017 .

PS I reply this issue in NVIDIA too.
Thanks.

xmrig added a commit that referenced this issue Feb 10, 2018
@xmrig xmrig added the bug label Feb 10, 2018
@xmrig
Copy link
Owner

xmrig commented Feb 10, 2018

Fixed in code now.
Thank you.

@Sinner181
Copy link
Author

Can you compile exe please?

I want keep your wallet for donate.

PS, nvidia have same problem. Thanks.

@Sinner181
Copy link
Author

No problem, I've just compile. For NVIDIA have some errors....I'm checking a solution....
Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants