Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reactivate CUDA 8.0 #74

Merged
merged 1 commit into from
Nov 8, 2020
Merged

Reactivate CUDA 8.0 #74

merged 1 commit into from
Nov 8, 2020

Conversation

Spudz76
Copy link
Contributor

@Spudz76 Spudz76 commented Oct 23, 2020

Enable algo options and full code omissions of disabled algos;
Reactivates CUDA 8.0

Allows for completely shutting off code that won't compile on CUDA 8.0 (RandomX, AstroBWT, and KawPow) while the resulting plugin works great for the other possible algos.

Compiling with CUDA 8.0 (or other versions) was accomplished in the added cmake/CUDA-Version.cmake which moves the CUDA Toolkit detections a step earlier so the main CMakeLists.txt can make decisions and route the user more appropriately to a working result. For example, compiling with an arch 20 option with some newer CUDA will explain why it won't work.

Any disabled algos will throw an unsupported condition so the plugin API still works appropriately, even with chunks of code carved out. Very similar to how the main miner does algo selections.

Have used very similar patch for quite some time now to compile working miners for arch-20 (or 21) devices. It is well tested in all my use cases.

@xmrig
Copy link
Owner

xmrig commented Oct 23, 2020

Thank you, I need some time to review, however changes in Algorithm.cpp are not required, plugin always deal with canonical algorithm names, there is no need for aliases.
Thank you.

@xmrig xmrig added the enhancement New feature or request label Oct 23, 2020
@xmrig xmrig merged commit 87b7039 into xmrig:dev Nov 8, 2020
@Spudz76 Spudz76 deleted the dev-algoOptions branch October 30, 2021 05:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants