-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix drivers completions #481
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handler/handler.go
Outdated
@@ -783,6 +783,7 @@ func (h *Handler) Open(ctx context.Context, params ...string) error { | |||
// force error/check connection | |||
if err == nil { | |||
if err = drivers.Ping(ctx, h.u, h.db); err == nil { | |||
h.l.Completer(drivers.NewCompleter(ctx, h.u, h.db, readerOpts(), completer.WithConnStrings(h.connStrings()))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a check for h.l.Interactive()
before calling this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in c0940a3.
I was thinking to also move the drivers.NewCompleter() call to |
Fixes #478
The drivers NewCompleter was removed from the handler between v0.18.1 and v0.19.0.
Tested locally, I had to cleanup the dependencies for go to build.