add support for custom VCC monitoring #1048
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with original
lobradov
suggested changes
Jul 18, 2018
| @@ -646,6 +646,17 @@ | |||
| #define ADC_MODE_VALUE ADC_VCC | |||
| #endif | |||
|
|
|||
| // custom Vcc mode (ADC_TOUT mode with correction) | |||
| #define ADC_VCC_CUSTOM 1 | |||
There was a problem hiding this comment.
why not make this a configuration parameter, guarded by ifndefs?
| #if ADC_MODE_VALUE == ADC_VCC | ||
| mqttSend(MQTT_TOPIC_VCC, String(ESP.getVcc()).c_str()); | ||
| #endif | ||
| int Vcc = custom_getVcc(ADC_MODE_VALUE); |
There was a problem hiding this comment.
if would be great to introduce this feature with conditions, like:
#if ADC_VCC_CUSTOM
int Vcc = custom_getVcc()
#else
int Vcc = ESP.getVcc()...
#endif
There was a problem hiding this comment.
ah, I see that it's actually done in custom_getVcc()
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom VCC monitoring with correction. enabled with defines:
// for example
#define ADC_MODE_VALUE ADC_VCC_CUSTOM
#define ADC_VCC_CUSTOM_MUL (15.63)
#define ADC_VCC_CUSTOM_ADD (0)
in hardware section description (hardware.h)