Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bad performance / CPU limit on act-4 maps #35

Open
wolfestridershooter opened this issue Nov 28, 2024 · 3 comments
Open

Bad performance / CPU limit on act-4 maps #35

wolfestridershooter opened this issue Nov 28, 2024 · 3 comments
Labels
bug

Comments

@wolfestridershooter
Copy link

Bug reported by wolfe_strider on Trello on November 5th

Description:
This happens in a bunch of act 4 maps

Example:
https://www.youtube.com/watch?v=T3jmYABFwAo
Preview image:
Image
@wolfestridershooter wolfestridershooter moved this to Bug in p2-rtx Nov 28, 2024
@xoxor4d
Copy link
Owner

xoxor4d commented Nov 30, 2024

This is happening due to other, larger map areas getting tagged as potentially visibility and thus, being rendered and is not related to the emncipation grill. The second layer of emancipation grill popping in and out of existance is already fixed.

@xoxor4d xoxor4d changed the title Emancipation Grill duplicate lowers framerate by nearly 10 frames Bad performance / CPU limit on act-4 maps Nov 30, 2024
@xoxor4d xoxor4d added the bug label Nov 30, 2024
@xoxor4d xoxor4d moved this from Bug to Code in p2-rtx Nov 30, 2024
@xoxor4d xoxor4d mentioned this issue Nov 30, 2024
Open
@xoxor4d
Copy link
Owner

xoxor4d commented Nov 30, 2024

#95

@xoxor4d xoxor4d moved this from Code to In progress in p2-rtx Nov 30, 2024
xoxor4d added a commit that referenced this issue Dec 1, 2024
@xoxor4d
[Perf] MapSettings: Use Frustumcull + hide areas/leafs #35 Close #95
bf68394
xoxor4d added a commit that referenced this issue Dec 10, 2024
@xoxor4d
Better portal vis culling - add game settings module #35
e8176ef 
- fix various culling related issues
- the exit portal is now doing proper area visibility checks resulting in less drawing
- area visible through the exit portal is now culled by default if the entry portal is not visible -> can be tweaked via game_settings.toml
- add game_settings module using file `portal2-rtx/game_settings.toml` (auto generates but accepts valid tweaks to settings
@wolfestridershooter
Copy link
Author

This is happening due to other, larger map areas getting tagged as potentially visibility and thus, being rendered and is not related to the emncipation grill. The second layer of emancipation grill popping in and out of existance is already fixed.

When I was testing this I had culling off using the old cvar at the time which is why I assumed it was due to the emancipation grill since my framerate dropped only when the duplicate was rendered and it happened when leaving the map so the only new thing to be rendered would be the elevator. Also the emancipation grill duplicates are still not fixed. #131

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
p2-rtx
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xoxor4d @wolfestridershooter