Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Report correctly on managed-dependencies #83

Closed
ikitommi opened this issue Oct 28, 2017 · 13 comments
Closed

Report correctly on managed-dependencies #83

ikitommi opened this issue Oct 28, 2017 · 13 comments
Labels

Comments

@ikitommi
Copy link

When versions are defined via :managed-dependencies, the report doesn't shot the version. eg..

(defproject kikka "0.1.0-SNAPSHOT"
  :managed-dependencies [[metosin/spec-tools "0.4.0"]]
  :dependencies [[metosin/spec-tools]])

with lein ancient it prints:

[metosin/spec-tools "0.5.0"] is available but we use ""

and thanks for the awesome plugin!

@xsc xsc added the bug label Oct 29, 2017
@danieltdt
Copy link

Any news about it?

@awb99
Copy link

awb99 commented Apr 1, 2020

yeah!! A fix for this would really help!

@awb99
Copy link

awb99 commented Apr 28, 2020

Is there anyone stil workinng on lein-ancient?
A fix for managed-dependenies to me is a pretty important feature. I know it is a new leiningen feature, so implementation will take a while. However, the reason to use lein-ancient is for BIG projects, where it is very difficult to manage dependencies. And such projects will use managed-dependencies sooner or later. THANKS!

@xsc
Copy link
Owner

xsc commented Apr 28, 2020

@awb99 I'm slowly finding time to get back into these projects. Since I have not been actively working on them for a few months, it might still take a bit until I've familiarized myself again.

Give me a bit of time - this doesn't look too hard to fix.

@xsc
Copy link
Owner

xsc commented Dec 23, 2020

About 3 years too late, but I just pushed [lein-ancient "0.7.0-SNAPSHOT"] which should incorporate a fix for this. Could one of you reading this check it out? Thanks!

@dancek
Copy link

dancek commented Jan 14, 2021

@xsc 0.7.0-SNAPSHOT fixed the issue for the parent project that has :managed-dependencies.

In a child project, however, all the dependencies are listed with version "". Child project meaning that the project.clj has

  :plugins [[lein-parent "0.3.8"]]
  :parent-project {:path    "modules/parent/project.clj"
                   :inherit [:managed-dependencies]}

In any case, the current fix is very useful. 👍

@dcarley
Copy link

dcarley commented Jan 14, 2021

I forgot to report it, but experienced the same 👍

@xsc
Copy link
Owner

xsc commented Jan 17, 2021

I deployed another SNAPSHOT that might fix the issue with parent projects. (It now uses the project map that Leiningen provides to find managed dependencies, instead of collecting them from the file itself.)

@dancek
Copy link

dancek commented Jan 18, 2021

@xsc this new snapshot version shows all artifacts are up-to-date. for a child project even when some of the dependencies are out of date. The parent project has correct version listings.

@xsc
Copy link
Owner

xsc commented Jan 18, 2021

@dancek Right now, the plugin won't check dependencies of the parent project if run in a child project. Is that what you mean or are there actual outdated dependencies in the child project's project.clj?

@dancek
Copy link

dancek commented Jan 18, 2021

@xsc yeah, that's what I meant. I have all the dependency versions in the parent project. I.e. I use the parent project mostly to keep multiple child projects using the same dependency versions.

@dancek
Copy link

dancek commented Jan 18, 2021

In any case, I think the current version is good for release.

@xsc
Copy link
Owner

xsc commented Jan 28, 2021

Current fix released in [lein-ancient "0.7.0"]. Tracking the parent dependency topic in #119, please share your opinion there. :)

@xsc xsc closed this as completed Jan 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants
@danieltdt @xsc @dancek @dcarley @ikitommi @awb99 and others