Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix sign of longitudinal wake when reading from headtail file #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xbuffat
Copy link

@xbuffat xbuffat commented Feb 28, 2025

Description

The sign convention of the longitudinal wake (positive means energy loss) is opposite to PyHT. The sign changed is adjusted in the conversion factor when reading the file.

Closes # .

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant