Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update space demo #2737

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Update space demo #2737

merged 1 commit into from
Feb 21, 2025

Conversation

hlohaus
Copy link
Collaborator

@hlohaus hlohaus commented Feb 21, 2025

No description provided.

@hlohaus hlohaus merged commit 4cfe35f into xtekky:main Feb 21, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Review: Update space demo

Thank you, H Lohaus, for contributing to the project!

Summary

This pull request includes two main changes:

  1. Update to the HuggingFace link in the README:

    • The link to the HuggingFace space has been updated from g4f-space to g4f-new.
    • The duplicate URL for the HuggingFace space has also been updated to reflect the new space URL.
  2. Modification to demo.html:

    • A new check for iframe context has been added (const isIframe = window.self !== window.top;), which conditionally modifies the button visibility.

Detailed Review

1. README Update:

  • The update to the README file is clear and improves the link structure by directing users to the new HuggingFace space (g4f-new). This is a good change as it ensures users are accessing the most up-to-date version of the demo.
  • The update is straightforward, and the old link now redirects to the new space. This change will prevent confusion for new users.

2. HTML Update:

  • The check for iframe context (const isIframe = window.self !== window.top;) seems like a useful improvement, especially if the demo is intended to be embedded in other pages. The button visibility change is likely aimed at preventing users from interacting with the demo when embedded in an iframe, improving the user experience.
  • The change seems minor but provides better control over the UI behavior.

Recommendations

  • Please ensure that the updated HuggingFace space (g4f-new) is fully functional and accessible.
  • Consider adding comments in demo.html for clarity, explaining the purpose of the isIframe check, especially for new contributors who may be unfamiliar with this behavior.

Overall, the changes look good, and this PR enhances the usability and clarity of the demo. Thanks again for your contribution!

Approved

The PR is approved and can be merged.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant