Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add fixed_shape::operator== #2382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tailsu
Copy link

@tailsu tailsu commented May 17, 2021

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description

Fixes #2376

@tailsu tailsu force-pushed the sd/fixed-shape-op-eq branch from 5e68454 to 20f6dac Compare May 17, 2021 10:34
@tailsu tailsu force-pushed the sd/fixed-shape-op-eq branch from 20f6dac to be35a26 Compare May 17, 2021 10:56
@tdegeus
Copy link
Member

tdegeus commented May 18, 2021

Thanks!

To deal with the compiler issues I think you would just need to remove

bool operator==(fixed_shape<I...>, fixed_shape<J...>)

Furthermore, I think you still use std::equal internally

@tdegeus
Copy link
Member

tdegeus commented May 18, 2021

Actually I think that an implementation is already under way:

#2352

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing operator== for xt::fixed_shape
2 participants