Always send response #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Aug 16, 2024
| } |
There was a problem hiding this comment.
I edited this file in GitHub UI, not sure why it added this trailing newline, let's see if I can remove it(?)
Suggested change
| } | |
| } |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Over in the OpenTelemetry Java Instrumentation project, we got a report about our project causing OOM when instrumenting xxl-rpc's netty usage (open-telemetry/opentelemetry-java-instrumentation#11942).
We have mitigated the OOM (open-telemetry/opentelemetry-java-instrumentation#12003), but we aren't able to correctly instrument netty when there's no response sent for a request (because we can't tell the difference between that and HTTP pipelining).
Is there any chance you'd accept this PR to send an empty response here, so that we can correctly instrument xxl-rpc? Thanks!