Fix payload of all dmaker.airfresh.t2017 toggles (rytilahti#854)

xvlady · May 9, 2021 · 716022c · 716022c
1 parent 77073df
commit 716022c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 18 deletions.
diff --git a/miio/airfresh_t2017.py b/miio/airfresh_t2017.py
@@ -283,12 +283,12 @@ def status(self) -> AirFreshStatus:
     @command(default_output=format_output("Powering on"))
     def on(self):
         """Power on."""
-        return self.send("set_power", ["on"])
+        return self.send("set_power", [True])
 
     @command(default_output=format_output("Powering off"))
     def off(self):
         """Power off."""
-        return self.send("set_power", ["off"])
+        return self.send("set_power", [False])
 
     @command(
         click.argument("mode", type=EnumType(OperationMode)),
@@ -306,10 +306,7 @@ def set_mode(self, mode: OperationMode):
     )
     def set_display(self, display: bool):
         """Turn led on/off."""
-        if display:
-            return self.send("set_display", ["on"])
-        else:
-            return self.send("set_display", ["off"])
+        return self.send("set_display", [display])
 
     @command(
         click.argument("orientation", type=EnumType(DisplayOrientation)),
@@ -345,10 +342,7 @@ def set_ptc_level(self, level: PtcLevel):
     )
     def set_buzzer(self, buzzer: bool):
         """Set sound on/off."""
-        if buzzer:
-            return self.send("set_sound", ["on"])
-        else:
-            return self.send("set_sound", ["off"])
+        return self.send("set_sound", [buzzer])
 
     @command(
         click.argument("lock", type=bool),
@@ -358,10 +352,7 @@ def set_buzzer(self, buzzer: bool):
     )
     def set_child_lock(self, lock: bool):
         """Set child lock on/off."""
-        if lock:
-            return self.send("set_child_lock", ["on"])
-        else:
-            return self.send("set_child_lock", ["off"])
+        return self.send("set_child_lock", [lock])
 
     @command(default_output=format_output("Resetting upper filter"))
     def reset_upper_filter(self):

diff --git a/miio/tests/test_airfresh_t2017.py b/miio/tests/test_airfresh_t2017.py
@@ -40,11 +40,11 @@ def __init__(self, *args, **kwargs):
         }
         self.return_values = {
             "get_prop": self._get_state,
-            "set_power": lambda x: self._set_state("power", [(x[0] == "on")]),
+            "set_power": lambda x: self._set_state("power", x),
             "set_mode": lambda x: self._set_state("mode", x),
-            "set_sound": lambda x: self._set_state("sound", [(x[0] == "on")]),
-            "set_child_lock": lambda x: self._set_state("child_lock", [(x[0] == "on")]),
-            "set_display": lambda x: self._set_state("display", [(x[0] == "on")]),
+            "set_sound": lambda x: self._set_state("sound", x),
+            "set_child_lock": lambda x: self._set_state("child_lock", x),
+            "set_display": lambda x: self._set_state("display", x),
             "set_screen_direction": lambda x: self._set_state("screen_direction", x),
             "set_ptc_level": lambda x: self._set_state("ptc_level", x),
             "set_ptc_on": lambda x: self._set_state("ptc_on", x),