Skip to content

Commit

Permalink
CRAPP-298: Bad rendering of title with UTF-8
Browse files Browse the repository at this point in the history
  * Fix rendering of the title
  • Loading branch information
surli committed Jun 27, 2023
1 parent feacb5c commit 7565e72
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
<input type="hidden" name="changeType" value="settitle" />
<h1 class="editable">
<span class="edit-title-icon">$services.icon.renderHTML('pencil')</span>
<label class="sr-only" for="edit-title-input">$doc.title</label>
<label class="sr-only" for="edit-title-input">$services.rendering.escape($doc.title, 'xwiki/2.1')</label>

This comment has been minimized.

Copy link
@michitux

michitux Jun 27, 2023

Shouldn't this rather be $escapetool.xml($doc.title)?

<input type="text" id="edit-title-input" name="new-title" value="$escapetool.xml($doc.title)" />
</h1>
<div class="title-button-wrapper hidden">
Expand Down

0 comments on commit 7565e72

Please # to comment.