Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add contributing.md and pull_request_template.md files #99

Merged
merged 3 commits into from
Sep 19, 2021
Merged

Add contributing.md and pull_request_template.md files #99

merged 3 commits into from
Sep 19, 2021

Conversation

ingydotnet
Copy link
Member

No description provided.

@ingydotnet ingydotnet requested a review from a team as a code owner August 5, 2021 23:37
@eemeli eemeli removed the request for review from a team August 6, 2021 09:15
@eemeli eemeli marked this pull request as draft August 6, 2021 09:15
@ingydotnet ingydotnet force-pushed the contributing branch 2 times, most recently from 6a465dd to a77d3c4 Compare August 7, 2021 20:21
@ingydotnet ingydotnet changed the title WIP - Add a .github/contributing.md file Add a .github/contributing.md file Aug 9, 2021
@ingydotnet ingydotnet force-pushed the contributing branch 2 times, most recently from 93d55ec to 871c6e9 Compare August 15, 2021 14:55
@ingydotnet ingydotnet force-pushed the contributing branch 3 times, most recently from f023a10 to d89da5b Compare August 28, 2021 14:36
@Thom1729 Thom1729 added the Infrastructure An infrastructure-only change that does not change the spec itself. label Sep 3, 2021
@ingydotnet ingydotnet changed the title Add a .github/contributing.md file Add contributing.md and pull_request_template.md files Sep 18, 2021
@ingydotnet ingydotnet marked this pull request as ready for review September 18, 2021 20:09
@ingydotnet ingydotnet requested a review from eemeli September 19, 2021 18:30
eemeli
eemeli approved these changes Sep 19, 2021
View reviewed changes
Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec/ links in contributing.md should be fully qualified.

@Thom1729
Copy link
Collaborator

contributing.md is fine. I'm not sure about the PR template.

perlpunk
perlpunk reviewed Sep 19, 2021
View reviewed changes
@ingydotnet ingydotnet merged commit 7a65304 into main Sep 19, 2021
@ingydotnet ingydotnet deleted the contributing branch September 19, 2021 23:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@perlpunk perlpunk perlpunk left review comments

@eemeli eemeli eemeli approved these changes

Assignees
No one assigned
Labels
Infrastructure An infrastructure-only change that does not change the spec itself.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ingydotnet @Thom1729 @eemeli @perlpunk