Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace all atari_util.py variations with an import from stable_baselines.common.atari_wrappers #273

Open
dniku opened this issue Aug 30, 2019 · 0 comments
Open

Replace all atari_util.py variations with an import from stable_baselines.common.atari_wrappers #273

dniku opened this issue Aug 30, 2019 · 0 comments
Labels
maintenance

Comments

@dniku
Copy link
Collaborator

dniku commented Aug 30, 2019

We have a bunch of atari_util.py variations:

master:week04_approx_rl/atari_wrappers.py
master:week06_policy_based/atari_wrappers.py
master:week08_pomdp/atari_util.py
coursera:week4_approx/atari_util.py
coursera:week5_policy_based/atari_util.py

Things can be simplified if we instead reuse https://github.com/hill-a/stable-baselines/blob/master/stable_baselines/common/atari_wrappers.py.
dniku added a commit that referenced this issue Aug 30, 2019
@dniku
Put reward scaling back in place
5550606 
This is a temporary measure until #273 is resolved.
dniku added a commit that referenced this issue Aug 30, 2019
@dniku
Put reward scaling back in place
6935d23 
This is a temporary measure until #273 is resolved.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dniku