Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Find ways to increase performance #14

Open
yargalot opened this issue Feb 22, 2016 · 10 comments
Open

Find ways to increase performance #14

yargalot opened this issue Feb 22, 2016 · 10 comments

Comments

@yargalot
Copy link
Owner

yargalot/grunt-accessibility#31 as per @XhmikosR's, previous issue

@XhmikosR
Copy link
Contributor

@yargalot: I notice the slowdown mostly happens on Windows.

Can you set up AppVeyor for this repo to see the slowdown yourself?

Example:

https://travis-ci.org/mpc-hc/mpc-hc.org/builds/171916862
https://ci.appveyor.com/project/XhmikosR/mpc-hc-org/build/691

Windows: accessibility:test 1m 14.9s
Linux: accessibility:test 6.4s

yargalot added a commit that referenced this issue Oct 31, 2016
#14 Start getting stats for performance testing
@yargalot
Copy link
Owner Author

@XhmikosR that makes sense, I've added it in over at https://ci.appveyor.com/project/yargalot/accesssniff

Im going to put in some benchmark tests and see whats going on. Also going to try it out using JSDom instead of phantomJS and see if that speeds things up.

yargalot added a commit that referenced this issue Nov 1, 2016
#14 performance tweaks. Set option.template to true in order to use JSDOM

Does not work with URLS at the moment
@yargalot
Copy link
Owner Author

yargalot commented Nov 1, 2016

jsdom is a ton faster

@yargalot
Copy link
Owner Author

yargalot commented Nov 1, 2016

Phantomjs x 0.24 ops/sec ±0.36% (6 runs sampled)
JSDom x 35.13 ops/sec ±9.06% (61 runs sampled)
Slowest is Phantomjs
Fastest is JSDom

@yargalot yargalot mentioned this issue Nov 6, 2016
@yargalot
Copy link
Owner Author

yargalot commented Nov 6, 2016

Done in 3.0

@yargalot yargalot closed this as completed Nov 6, 2016
@yargalot
Copy link
Owner Author

yargalot commented Nov 6, 2016

@XhmikosR can you give the 5.0 grunt accessibility update a shot and see how it is?

@XhmikosR
Copy link
Contributor

XhmikosR commented Nov 6, 2016

@yargalot: now it's consistently a lot more slower both on Linux and Windows :/

https://travis-ci.org/mpc-hc/mpc-hc.org/builds/173637062
https://ci.appveyor.com/project/XhmikosR/mpc-hc-org/build/694

@yargalot
Copy link
Owner Author

yargalot commented Nov 7, 2016

Hrmmm, l've got your repo on the laptop. Ill run some benchmarks tonight and see whats up

@yargalot yargalot reopened this Nov 7, 2016
@yargalot
Copy link
Owner Author

@XhmikosR Can you set the browser to true in options and see if its any quicker?

@XhmikosR
Copy link
Contributor

XhmikosR commented Nov 12, 2016

@yargalot: with browser:true it's as fast as it was with v4.x.

https://travis-ci.org/mpc-hc/mpc-hc.org/builds/175295062
https://ci.appveyor.com/project/XhmikosR/mpc-hc-org/build/695

Still Windows is a lot slower.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants