-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix: Ignore multiple spaces between arguments. #100
Conversation
f0d2276
to
29737fe
Compare
29737fe
to
3de8575
Compare
@Mike111177 hey 👋 do to some other potential parsing issues I thought of with the parsing around maintaining quotes, I opted to rollback the logic surrounding tldr; since most command lines already strip Do you mind potentially rebasing your work with master, taking into account that this logic has been removed? |
3de8575
to
ad5a04f
Compare
@bcoe Done. |
@Mike111177 thanks for the contribution. |
@Mike111177 this is now released in |
@bcoe It now works as I was hoping, multiple space between arguments are now ignored and undefined are not inserted in the middle of the token array. I did notice however that when the are spaces at the beginning of the argstring, it will still add undefined's to the beginning. I did not test it for endings, however it could be solved by doing a trim() on the argstring before tokenizing it. |
@Mike111177 👍 I would happily accept a patch for the follow on I have all of yargs' car parts spread out over the garage right now working on this, if you have any feedback on this front. |
Fixes #99