Skip to content

Commit

Permalink
Fix (partially) Svelte E2E test (#6428)
Browse files Browse the repository at this point in the history
## What's the problem this PR addresses?

The SvelteKit E2E test has been failing

## How did you fix it?

- `create-svelte` discontinued the `next` dist-tag, use `latest` instead
- I don't know how it was but `yes` cannot defeat `create-svelte`
interactivity now, so I just use its node API instead
- Also added a TypeScript test

The test should still be failing due to
sveltejs/kit#11433 (comment), but
at least it is an actual failure of the E2E test, not of our setup.
:shrug:

Closes #6345

## Checklist

<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

---------

Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
  • Loading branch information
clemyan and merceyz authored Oct 15, 2024
1 parent d85532f commit 2243ce9
Showing 1 changed file with 24 additions and 1 deletion.
25 changes: 24 additions & 1 deletion .github/workflows/e2e-svelte-kit-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,29 @@ jobs:
- name: 'Running the integration test'
run: |
source scripts/e2e-setup-ci.sh
yes | yarn create svelte@next my-app && cd my-app
yarn init -p
yarn add -D create-svelte@latest
yarn node -e "import('create-svelte').then(({create}) => create('my-app', {name:'my-app', template:'default', types:null}))"
cd my-app
touch yarn.lock
yarn
yarn build
- name: 'Running the TypeScript integration test'
run: |
source scripts/e2e-setup-ci.sh
yarn init -p
yarn add -D create-svelte@latest
yarn node -e "import('create-svelte').then(({create}) => create('my-app', {name:'my-app', template:'default', types:'typescript'}))"
cd my-app
touch yarn.lock
yarn
yarn build
if: |
success() || failure()

0 comments on commit 2243ce9

Please # to comment.