Skip to content

fix(compat): update patch for typescript@5.4.1-rc #6134

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Feb 20, 2024

What's the problem this PR addresses?

The PnP compatibility patch for TypeScript doesn't apply to typescript@5.4.1-rc.

Ref microsoft/TypeScript#35206

How did you fix it?

Rebased it.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz force-pushed the merceyz/fix/typescript-54-rc branch from f5e8b83 to 5d64120 Compare February 22, 2024 18:59
@merceyz merceyz marked this pull request as ready for review February 22, 2024 19:00
@arcanis arcanis merged commit aa2eebd into master Mar 4, 2024
@arcanis arcanis deleted the merceyz/fix/typescript-54-rc branch March 4, 2024 19:14
merceyz added a commit that referenced this pull request Mar 4, 2024
**What's the problem this PR addresses?**

The PnP compatibility patch for TypeScript doesn't apply to
`typescript@5.4.1-rc`.

Ref microsoft/TypeScript#35206

**How did you fix it?**

Rebased it.

**Checklist**
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

(cherry picked from commit aa2eebd)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants