Allow any registry to be used for auditing #6484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also experiencing this same problem |
|
Duplicate of #7263. Hi @cheesestringer, I suggest you closing this pull request and applying your knowledge on reviewing the #7263 |
Fix linting error Fix linting error
cheesestringer
force-pushed
the
master
branch
from
01e05c4 to
4fa3d19
Compare
|
Forgot all about this. Fixed the conflicts but happy to close this for the newer PR. |
|
Any updates regarding this? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow auditing against any registry. This is useful for auditing against a private or whitelisted registry.
For example, in our organisation npmjs is allowed while yarnpkg is blocked :(
Test plan
Command:
yarn auditOutput:
An unexpected error occurred: "https://registry.yarnpkg.com/-/npm/v1/security/audits: getaddrinfo ENOTFOUND registry.yarnpkg.com registry.yarnpkg.com:443".Command:
yarn audit --registry https://registry.npmjs.orgOutput:
0 vulnerabilities found - Packages audited: 46500Command:
yarn audit --registry https://artifactory.dev.company/artifactory/api/npm/npm-devOutput:
error Your configured registry "https://artifactory.dev.company/artifactory/api/npm/npm-dev" does not support audit requests.