Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix failing test #155

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Fix failing test #155

merged 1 commit into from
Apr 12, 2019

Conversation

LitoMore
Copy link
Contributor

Fix #153

LitoMore
LitoMore commented Apr 11, 2019
View reviewed changes
test/notify.js
@@ -21,7 +21,7 @@ function Control(shouldNotifyInNpmScript) {
const setupTest = isNpmReturnValue => {
['..', 'is-npm'].forEach(clearModule);
process.stdout.isTTY = true;
mock('is-npm', isNpmReturnValue || false);
mock('is-npm', {isNpm: isNpmReturnValue || false});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API of is-npm@3.0.0 has been changed. So I updated the mock export.

LitoMore
LitoMore commented Apr 11, 2019
View reviewed changes
package.json
@@ -13,7 +13,7 @@
"node": ">=8"
},
"scripts": {
"test": "xo && ava --timeout=20s"
"test": "xo && ava --timeout=20s -s"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should run tests serially for solving the conflict of mock require.

@SBoudrias
Copy link
Member

Thanks!!

@SBoudrias SBoudrias merged commit 79e89ad into yeoman:master Apr 12, 2019
@LitoMore LitoMore deleted the fix-test branch April 12, 2019 09:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix failing test
2 participants
@LitoMore @SBoudrias