-
Notifications
You must be signed in to change notification settings - Fork 43
refactor: lerna-lite #347
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: lerna-lite #347
Conversation
bb75d85
to
6e3f120
Compare
There we go, got it working. |
I tried to debug the flake, but 🤷♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the project to use lerna-lite by updating build dependencies and configuration files. Key changes include:
- Updating package.json to remove redundant fields, add lerna-lite dependencies, and bump versions.
- Modifying lerna.json to reference the new schema and enable workspace support.
- Updating Yarn configuration, Node version files, and CI workflows (including Corepack installation and Codecov action upgrade).
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
package.json | Updated version, dependency changes, and cleanup of fields. |
lerna.json | Adjusted configuration to use lerna-lite schema and workspaces. |
.yarnrc.yml | Removed explicit yarnPath in favor of Corepack and updated Yarn settings. |
.nvmrc | Added Node version configuration. |
.github/workflows/main.yml | Updated steps for Node version management, Corepack installation, and Codecov integration. |
Comments suppressed due to low confidence (1)
package.json:3
- The package version has been reset from 0.4.0 to 0.0.0; please confirm that this change aligns with your versioning strategy for this refactor.
"version": "0.0.0",
Didn't flake for once 🥳 lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more comment, thank you for your work.
& bump yarn, turbo, codecov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lishaduck Thanks for doing this, it's awesome!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 77 77
Lines 2420 2420
Branches 660 660
=======================================
Hits 2377 2377
Misses 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Checklist
Addresses comment:
Originally posted by @yeonjuan in #345 (comment)
Description
Bump build dependencies.