Skip to content

refactor: lerna-lite #347

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

refactor: lerna-lite #347

merged 1 commit into from
May 21, 2025

Conversation

lishaduck
Copy link
Contributor

Checklist

Addresses comment:

Since we're only using a very small subset of Lerna's features, I think it's a good idea.

Originally posted by @yeonjuan in #345 (comment)

Description

Bump build dependencies.

@lishaduck lishaduck force-pushed the lerna-lite branch 3 times, most recently from bb75d85 to 6e3f120 Compare May 19, 2025 17:20
@lishaduck
Copy link
Contributor Author

There we go, got it working.

@lishaduck
Copy link
Contributor Author

I tried to debug the flake, but 🤷‍♂️

@yeonjuan yeonjuan requested review from Copilot and yeonjuan May 20, 2025 14:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the project to use lerna-lite by updating build dependencies and configuration files. Key changes include:

  • Updating package.json to remove redundant fields, add lerna-lite dependencies, and bump versions.
  • Modifying lerna.json to reference the new schema and enable workspace support.
  • Updating Yarn configuration, Node version files, and CI workflows (including Corepack installation and Codecov action upgrade).

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updated version, dependency changes, and cleanup of fields.
lerna.json Adjusted configuration to use lerna-lite schema and workspaces.
.yarnrc.yml Removed explicit yarnPath in favor of Corepack and updated Yarn settings.
.nvmrc Added Node version configuration.
.github/workflows/main.yml Updated steps for Node version management, Corepack installation, and Codecov integration.
Comments suppressed due to low confidence (1)

package.json:3

  • The package version has been reset from 0.4.0 to 0.0.0; please confirm that this change aligns with your versioning strategy for this refactor.
"version": "0.0.0",

@lishaduck
Copy link
Contributor Author

Didn't flake for once 🥳 lol

Copy link
Owner

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment, thank you for your work.

& bump yarn, turbo, codecov
Copy link
Owner

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lishaduck Thanks for doing this, it's awesome!

@yeonjuan yeonjuan merged commit 5d15eed into yeonjuan:main May 21, 2025
5 checks passed
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (3235455) to head (89feecf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          77       77           
  Lines        2420     2420           
  Branches      660      660           
=======================================
  Hits         2377     2377           
  Misses         43       43           
Flag Coverage Δ
unittest 98.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lishaduck lishaduck deleted the lerna-lite branch May 21, 2025 14:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants