Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

When you open the PDF, when you try to override, can not be control. #94

Closed
daijinload opened this issue Oct 3, 2016 · 4 comments · Fixed by #113
Closed

When you open the PDF, when you try to override, can not be control. #94

daijinload opened this issue Oct 3, 2016 · 4 comments · Fixed by #113
Labels
bug Windows
Milestone
v0.0.10

Comments

@daijinload
Copy link

My PC is Windows7.
It is not a critical.
I can be closed using the Task Manager.
@yhatt
Copy link
Owner

yhatt commented Oct 8, 2016

Thank you reporting. This issue is also occurred in my Windows 10 when I had opened PDF file in the other process (e.g. Adobe Reader).

Currently Marp can't detect file locking state. I would keep investigating the cause...

@daijinload
Copy link
Author

Thanks for watching.

I created eletctron test-project in my repository.
printToPDF error handling is correctly moving.
Please look at your error handling.

yhatt added a commit that referenced this issue Nov 1, 2016
@yhatt
Fix the error handling at writing the file (Resolve #94)
ebd7cfc
@yhatt
Copy link
Owner

yhatt commented Nov 1, 2016

Oh, I know. Marp's error handling is not correctly.
We would fix it as to show dialog when saving to locked file.

@yhatt yhatt added this to the v0.0.9.1 milestone Nov 1, 2016
@yhatt yhatt mentioned this issue Nov 1, 2016
Merged
@yhatt
Copy link
Owner

yhatt commented Nov 6, 2016

We merged #113. Marp v0.0.10 (as known as v0.0.9.1) is going to release soon.

@yhatt yhatt closed this as completed in #113 Nov 6, 2016
yhatt added a commit that referenced this issue Nov 6, 2016
@yhatt
Merge pull request #113 from yhatt/correctly-err-handling-on-writefile
dc1634c 
Fix #94: Correct the error handling when writing file
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
bug Windows
Projects
None yet
Milestone
v0.0.10
Development

Successfully merging a pull request may close this issue.

Fix #94: Correct the error handling when writing file yhatt/marp
2 participants
@yhatt @daijinload