Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Fix #34: Relative path support improved by using base tag #49

Merged
merged 4 commits into from
Jul 23, 2016

Conversation

yhatt
Copy link
Owner

@yhatt yhatt commented Jul 22, 2016

I improved relative path support by using <base> html tag.

v0.0.8 can not resolve relative path except markdown's image format (![]()). But now <base> tag's href attribute can set specific starting directory for resolve. It means relative path would be supported in <img> tag and your custom styling.

relative-path

This affect Marp resource's path (CSS, Throbber). So I made path resolver for these.

@yhatt
Copy link
Owner Author

yhatt commented Jul 22, 2016

Oops. The image path in the last slide of Gaia theme example is wrong.

@yhatt
Copy link
Owner Author

yhatt commented Jul 22, 2016

I fixed the example. However I found a new bug of absolute path.

The path splitter \ in Windows makes the path conversion fail in only Markdown format ![]() only. (¥ means same in Japanese Windows, and its rendering is reported already at #46)

marp_absolute_path

I'll fix its counterintuitive behavior because of it affects to the feature of quick image insertion by D&D.

@yhatt
Copy link
Owner Author

yhatt commented Jul 23, 2016

OK. a4a69dc fixed the problem of absolute path by reverting previous custom renderer. And it still has the improved path resolver.

I would merge it if we have not seen the other problems.

@yhatt yhatt merged commit e088497 into master Jul 23, 2016
@yhatt yhatt deleted the improve-resolving-relative-path branch July 23, 2016 13:16
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant