-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Notional fCash as collateral #378
Conversation
There is actually an ERC1155 wrapper for fCash |
|
||
fCash positions can be positive or negative. If positive they are equivalent for a lending position, and are redeemable at maturity for their face value. If negative they are borrowing positions. | ||
|
||
We want to use fCash lending positions as collateral. Given that we know that they are redeemable for their face value at maturity and their volatility is low, they are good assets for that purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we fairly certain on this? Should we consider if they are hacked or something and the face value cannot be redeemed?
Overall looks good. I didn't find any dealbreakers, just some suggestions and a couple questions. Deploy scripts will be in a different pr, right? And we will be doing some mainnet fork tests at that time I guess? Two things to track when doing the mainnet fork tests are:
I'm happy to approve this after a little more discussion on some of the questions I brought up, the actual code change suggestions are not that important to me |
No one of you found the brown m&m. Tsk, tsk. |
I'm merging this PR now, thanks for the feedback received. It remains a bit of thinking on how to reorganize the repository for continued development. |
Check the README for more details.
All files have been stored in
contracts/other/notional
. We can have a discussion on how to organize this repo better.other
, which would also mean moving a bunch of oracles.utils
.Join1155
could go into ajoins
folder since it is not specific to any solution.