-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support self_contained for embedded audio #353
Comments
Done. You can install and test the development version via remotes::install_github('yihui/xaringan') Thanks! |
Thanks for doing this so quick! It Knits, but the audio won't play in the resulting HTML document. The current HTML document generated is like:
It works if I hack it to be like:
Can that be tweaked? |
@robertfromont Oops, sorry about the oversight. Yes, I should have selected |
Works, thanks! |
It turns out that media structured |
It would be great if HTML audio tags like
<audio controls><source src="something.wav" type="audio/wav"></audio>
caused the audio file to be included in the output .html file like images are, whenself_contained
is true.By filing an issue to this repo, I promise that
xfun::session_info('xaringan')
. I have upgraded all my packages to their latest versions (e.g., R, RStudio, and R packages), and also tried the development version:remotes::install_github('yihui/xaringan')
.I understand that my issue may be closed if I don't fulfill my promises.
The text was updated successfully, but these errors were encountered: