Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

commit new template #323

Merged
merged 5 commits into from
Jun 16, 2021
Merged

commit new template #323

merged 5 commits into from
Jun 16, 2021

Conversation

svd09
Copy link
Contributor

@svd09 svd09 commented Jun 13, 2021 •
edited
Loading

To contribute to this repo, please make sure to:

  • Sign the CLA (contributor license agreement). The CLA assistant will remind you below if you have not signed the agreement before.
  • Add a news item to NEWS.md and your name to DESCRIPTION (by alphabetical order) unless you have already been listed there.
  • Provide a URL to a live example (and even better, a couple of screenshots) if you are contributing a new theme.

Thank you!

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@svd09
Copy link
Contributor Author

svd09 commented Jun 13, 2021

Added the lines in the Readme.MD and DESCRIPTION files

@svd09
Copy link
Contributor Author

svd09 commented Jun 15, 2021

Link to the demo slides here

yihui
yihui requested changes Jun 15, 2021
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind renaming glasgow_template.css to glasgow.css? Thanks!

svd09 and others added 2 commits June 15, 2021 16:30
@svd09 @yihui
Update DESCRIPTION
ba44375 
Co-authored-by: Yihui Xie <xie@yihui.name>
@svd09 @yihui
Update NEWS.md
7c94e29 
Co-authored-by: Yihui Xie <xie@yihui.name>
@svd09
Copy link
Contributor Author

svd09 commented Jun 15, 2021

Made the change to the name from glasgow_template.css to glasgow.css
Thank you

@svd09 svd09 requested a review from yihui June 16, 2021 15:50
yihui
yihui approved these changes Jun 16, 2021
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yihui yihui merged commit 425b23c into yihui:master Jun 16, 2021
@yihui yihui mentioned this pull request Jun 16, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svd09 @CLAassistant @yihui