Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make isFALSE() like base::isFALSE() #71

Closed
wants to merge 1 commit into from
Closed

Make isFALSE() like base::isFALSE() #71

wants to merge 1 commit into from

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Nov 24, 2022

fix yihui/knitr#2199

Proposal to make xfun::isFALSE() same as base::isFALSE()

@yihui
Copy link
Owner

yihui commented Nov 24, 2022

Perhaps #67 is a better way to move forward? R 3.5.0 was released in April 2018, and I don't think a lot of people would see the deprecation message.

@cderv
Copy link
Collaborator Author

cderv commented Nov 24, 2022

Agreed. #67 is a better way forward.

Closing in favor of #67

@cderv cderv closed this Nov 24, 2022
@yihui yihui deleted the isFALSE branch December 13, 2022 04:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

knitr::knit() evaluates chunk if false value of eval chunk option has a comment.
2 participants