Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable sort when limit is explicit #201

Merged
merged 20 commits into from
Oct 21, 2024
Merged

Conversation

samdark
Copy link
Member

@samdark samdark commented Sep 29, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@samdark samdark requested a review from vjik September 29, 2024 11:58
samdark and others added 2 commits September 30, 2024 16:10
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@samdark samdark requested a review from vjik October 17, 2024 21:01
@samdark
Copy link
Member Author

samdark commented Oct 18, 2024

Applied suggestions and fixed some additional stuff.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about similar fixes in KeysetPaginator?

@samdark
Copy link
Member Author

samdark commented Oct 20, 2024

@vjik good suggestions. Applied.

@samdark samdark requested a review from vjik October 20, 2024 10:56
@vjik vjik merged commit a080786 into master Oct 21, 2024
16 of 17 checks passed
@vjik vjik deleted the disable-sort-when-limit-is-explicit branch October 21, 2024 08:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants