Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #202: Check that correct sort is passed to withSort() of keyset paginator #209

Merged
merged 4 commits into from
Oct 19, 2024

Conversation

samdark
Copy link
Member

@samdark samdark commented Oct 17, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

@samdark samdark requested a review from vjik October 17, 2024 20:55
@samdark samdark changed the title Check that correct sort is passed to withSort() of keyset paginator Fix #202: Check that correct sort is passed to withSort() of keyset paginator Oct 17, 2024
@samdark samdark linked an issue Oct 17, 2024 that may be closed by this pull request
@samdark samdark requested a review from vjik October 18, 2024 21:10
@vjik vjik merged commit 8739893 into master Oct 19, 2024
16 of 17 checks passed
@vjik vjik deleted the 202-check-sort branch October 19, 2024 15:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method KetsetPaginator::withSort() must check that sort is not null
3 participants