Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove QueryBuilder::getColumnType() child method #297

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 1, 2023

Remove legacy code

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Aug 1, 2023

PR Summary

  • Modification to getColumnType method in QueryBuilder.php
    • The function has been streamlined. It no longer performs an extra, specific column type check, but directly provides the result from the parent class. This increase in efficiency can aid in improving the overall performance.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (463bab4) 99.11% compared to head (42bac4e) 99.10%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #297      +/-   ##
============================================
- Coverage     99.11%   99.10%   -0.01%     
+ Complexity      191      188       -3     
============================================
  Files            13       13              
  Lines           565      560       -5     
============================================
- Hits            560      555       -5     
  Misses            5        5              
Files Changed Coverage Δ
src/QueryBuilder.php 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review August 4, 2023 03:26
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line for CHANGELOG. Thanks.

@terabytesoftw terabytesoftw merged commit 70ed4d9 into yiisoft:master Aug 16, 2023
@Tigrov Tigrov deleted the remove_legacy_code branch August 17, 2023 01:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants